Alex Xu (Hello71)
4797c120d0
ci: set umask instead of ARTI_FS_DISABLE_PERMISSION_CHECKS
2022-05-25 10:27:45 -04:00
Ian Jackson
4b0459d204
Merge branch 'bug475' into 'main'
...
ConfigurationSources: Allow config files to be world-readable.
Closes #475
See merge request tpo/core/arti!528
2022-05-25 14:23:12 +00:00
Nick Mathewson
bc3c9d475f
Merge branch 'support_policy' into 'main'
...
Initial draft policy on supported platforms and dependencies
Closes #379
See merge request tpo/core/arti!513
2022-05-25 13:14:54 +00:00
Nick Mathewson
52a338a378
Merge branch 'socks-errors' into 'main'
...
reply socks error on more codepath
Closes #258
See merge request tpo/core/arti!531
2022-05-25 13:13:18 +00:00
Nick Mathewson
3b837eb7f4
Typo fixes (automated with "typos").
2022-05-24 19:21:12 -04:00
trinity-1686a
801380780f
reply socks error on more codepath
2022-05-25 00:02:14 +02:00
Nick Mathewson
92f0f97fe8
Merge branch 'isolation-example' into 'main'
...
add example for Isolation
Closes #414
See merge request tpo/core/arti!524
2022-05-24 19:34:14 +00:00
eta
608d0cbcc2
Merge branch 'bug482' into 'main'
...
DirMgr: Stop load-from-cache process when there is no change.
Closes #482
See merge request tpo/core/arti!527
2022-05-24 19:33:42 +00:00
Nick Mathewson
460117f2b0
Allow use of RetainMut, since we do not require Rust 1.61 yet.
2022-05-24 15:09:00 -04:00
Nick Mathewson
af54b99b40
Run "cargo update" in preparation for the next release.
2022-05-24 15:08:01 -04:00
Nick Mathewson
f395c5d470
Start work on a changelog for 0.4.0
2022-05-24 15:05:57 -04:00
trinity-1686a
78b815e0d3
mention isolation is an advanced topic and most usage don't require implementing the trait
2022-05-24 18:25:32 +02:00
Nick Mathewson
b055cc27f1
Merge branch 'configurable-mistrust' into 'main'
...
Make file permissions configurable via regular config mechanisms
Closes #465
See merge request tpo/core/arti!515
2022-05-24 15:19:20 +00:00
Ian Jackson
814faf6398
Apply clarifications to SupportPolicy.md from @Diziet
2022-05-24 15:13:54 +00:00
Nick Mathewson
5a5a828db6
ConfigurationSources: Allow config files to be world-readable.
...
Fixes #475 .
2022-05-24 11:05:57 -04:00
Nick Mathewson
924cc380d4
Use serde attrs instead of manual impls
2022-05-24 10:54:02 -04:00
Nick Mathewson
de3c7baa4c
Note that fs-mistrust has broken semver.
2022-05-24 10:54:02 -04:00
Nick Mathewson
25c64db575
Apply fs-mistrust to logfile directories.
2022-05-24 10:54:02 -04:00
Nick Mathewson
b1fc4bd03b
Make fs-mistrust configurable from the top level.
...
This change requires a little refactoring of TorClientBuilder: now,
instead of enabling or disabling mistrust, it enables or disables
the decision to _override_ the mistrust in the config.
2022-05-24 10:54:02 -04:00
Nick Mathewson
12f2a47fcb
Write custom serde impls for Trusted{User,Group}
...
We support all of the following (in TOML notation):
```
user = "rose" # by name
user = 413 # by ID
user = false # no user
user = ":current" # A 'special' user.
user = { name: "rose" }
user = { id: 413 }
user = { special: ":none" }
user = { special: ":current" }
```
2022-05-24 10:54:02 -04:00
Nick Mathewson
9dd7b99de1
Add serde derives for MistrustBuilder.
...
The Group and User (de)serialization is pretty ugly, and I can't
vouch for the correcness of MistrustBuilder. I will seek feedback
before I proceed.
2022-05-24 10:54:02 -04:00
Nick Mathewson
330582a142
fs-mistrust: Add Group and User types.
...
This will help make the actual configuration more serializable,
I hope.
2022-05-24 10:54:02 -04:00
Nick Mathewson
95200383b5
fs-mistrust: make Mistrust have a corresponding Builder type.
...
This is an approximately minimal revision to get Builder in place;
subsequent commits will clean up the API.
2022-05-24 10:54:02 -04:00
Nick Mathewson
baa58daace
fs-mistrust: rename fields
...
This renaming will make things slightly simpler for declaring a
builder.
2022-05-24 10:54:02 -04:00
Ian Jackson
85faa1c0f6
Merge branch 'upgrades-20220523' into 'main'
...
Update to newer sanitize-filename and tinystr.
See merge request tpo/core/arti!523
2022-05-24 13:22:01 +00:00
Ian Jackson
dae2ccd692
Merge branch 'clippy_pass' into 'main'
...
Make clippy +nightly pass again
See merge request tpo/core/arti!522
2022-05-24 13:21:24 +00:00
Nick Mathewson
8e15c97f56
DirMgr: Stop load-from-cache process when there is no change.
...
Previously in !511 I had introduced a bug where, if there was an
error more serious than "no change", that error would keep us from
noticing that we had no change, and we'd loop until the safety
counter ran out. Then we'd panic.
This commit fixes the bug by reintroducing the `changed` boolean --
this time as an outparam for the add_from_* methods.
Fixes #482 .
2022-05-24 08:50:20 -04:00
trinity-1686a
b279b09b0c
add example for Isolation
2022-05-23 22:40:08 +02:00
Nick Mathewson
c27b3cb701
Update to newer sanitize-filename and tinystr.
2022-05-23 16:02:50 -04:00
Nick Mathewson
90b8a927a3
Merge branch 'check-pid-squashed'
2022-05-23 13:08:03 -04:00
Jim Newsome
48e1c75584
chutney/teardown: validate that pid is set
2022-05-23 13:07:59 -04:00
Nick Mathewson
546ae3000e
Resolve the new `derive_partial_eq_without_eq` lint.
...
It's a little overzealous sometimes, but it's mostly to the good.
2022-05-23 12:55:37 -04:00
Nick Mathewson
2f1803f4c6
Suppress clippy warnings in tor-basic-utils.
...
These are warnings that we've decided it's okay to suppress elsewhere.
2022-05-23 12:55:37 -04:00
Nick Mathewson
aaa8bfcb53
Merge branch 'remove_dbgs' into 'main'
...
Remove dbg!()s in tor-config, and fix nightly CI
See merge request tpo/core/arti!516
2022-05-23 16:18:46 +00:00
eta
0861827d90
Merge branch 'update-min-async-compression' into 'main'
...
async-compression minimum version 0.3.5 -> 0.3.14
Closes #473
See merge request tpo/core/arti!521
2022-05-23 15:43:28 +00:00
eta
55ce1fea79
Merge branch 'streamprefs-test' into 'main'
...
add unit tests for arti_client::StreamPrefs
See merge request tpo/core/arti!520
2022-05-23 15:41:26 +00:00
Jim Newsome
e33cae6cb6
async-compression minimum version 0.3.5 -> 0.3.14
...
0.3.14 is the first released version to include
e724673876
,
which fixes https://gitlab.torproject.org/tpo/core/arti/-/issues/473
2022-05-23 10:01:18 -05:00
michael mccune
0d8f520faf
add unit tests for arti_client::StreamPrefs
...
this change adds unit tests for the public methods of StreamPrefs. although
these are mostly "setter" style functions, the tests confirm the basic
expectations and operation.
2022-05-23 10:55:17 -04:00
Ian Jackson
60551711b8
Merge branch 'channel' into 'main'
...
channel: Provide and use Sink::prepare_send_from
See merge request tpo/core/arti!514
2022-05-23 11:39:39 +00:00
Ian Jackson
2fc6c8a194
prepare_send_from: clippy: Replace some or_else with or
2022-05-23 11:28:05 +01:00
Ian Jackson
86d5768c05
prepare_send_from: clippy: Have dprintln explicitly return ()
2022-05-23 11:28:05 +01:00
Ian Jackson
d3f261d5ef
prepare_send_from: clippy: Avoid a lint
...
I think this is worse code, but it's not *significantly* worse.
2022-05-23 11:28:05 +01:00
Ian Jackson
24dde5ddf1
prepare_send_from: clippy: Add missing docs
...
I intend to reintroduce this in its own MR.
2022-05-23 11:28:05 +01:00
Ian Jackson
739e5b52b1
prepare_send_from: clippy: Replace two unwraps
2022-05-23 11:28:05 +01:00
Ian Jackson
94038a9227
prepare_send_from: Break out get_output! macro
...
So we can change unwrap to expect, which makes this too long to repeat.
2022-05-23 11:28:05 +01:00
Ian Jackson
9fd0050acf
prepare_send_from: docs and comments improvements
...
Apropos review.
2022-05-23 11:28:05 +01:00
Ian Jackson
426ff28b73
prepare_send_from: Add tests
...
When I added these tests, they didn't find any bugs in my own
implementation, but I did find a bug in futures::future::unfold.
See the in-code comment.
2022-05-23 11:28:05 +01:00
Ian Jackson
793782acc8
channel: Provide and use Sink::prepare_send_from
...
This is a general-purpose implementation of the ad-hoc approach
currently taken in (eg) crates/tor-proto/src/channel/reactor.rs,
with an API intended to defned against the more obvious mistakes.
This allows us to separate the two concerns: the channel reactor can
focus on handling channel cells and control messages and is over 2.5x
shorter.
The complexity of the manual sink implementation, and the machinery
needed to avoid having to suspend while holding an item, are dealt
with separately. That separate implemenation now has proper
documentation. (Tests are in the nest commit to avoid this one being
even more unwieldy.)
We use `extend` to define this as an extension trait. A competitor is
`ext` but in my personal projects I have found `extend` slightly
better.
2022-05-23 11:28:05 +01:00
eta
b137d64e18
Update Gitlab CI config for Gitlab 14.10
...
see https://gitlab.com/gitlab-org/gitlab/-/issues/344533
2022-05-23 10:14:09 +00:00
eta
a6c7818d8e
Merge branch 'update-async-compression' into 'main'
...
async-compression v0.3.12 -> v0.3.14
Closes #473
See merge request tpo/core/arti!517
2022-05-23 09:59:44 +00:00